Why Didn't He Get the Job? Let's Find Out! // Code Review

Your move, Дмитро. Don’t forget you can try everything Brilliant has to offer—free—for a full 30 days, visit brilliant.org/TheCherno . You’ll also get 20% off an annual premium subscription.

Pro-tip: Always try to build your project on a completely different computer before you submit it.

This is a prime example of "It works on my computer"

On his way to a complete game, he forgot how to run the game.

Harsh but deserved, as an applicant you must act as if you were advertising yourself, straight to the point, you gotta give an easy path to the good stuff to the interviewer.

The game is the build we fixed along the way

You weren't harsh at all tbh, even as a friend or colleague I would be like "dude, shit ain't working".

While I agree on every single point you make. I will like for everybody to step back and appreciate how ridiculous the build process is in C++. It is absolute madness. CMake was created by a completely insane person. It is important for juniors to realize that they are not stupid. The system itself is crazy. You don't have to learn just the language. You need to learn about toolchains. different compilers, ... . In mid to big projects you will have people just dedicated to maintain the build system. It is wasteful, unnecessary, and stupid.

"Please roast code at full capacity" Shouldn't have said that blud

I always try to make it a three step process in the readme… 1. Git clone 2. Cd; build 3. Run

This code was sponsored by IKEA. You need to assemble it yourself

That's not a code review. That's a code roast 🤣

Powershell is actually cross-platform, and has been for a while. But that still doesn't explain using it for a build step where all you do is call cmake.

This is why all my projects have CI/CD pipelines that automatically sends a random person from Fiverr a request to install and run my program. It also sets up a video conference call using an AI avatar to check if they were able to do it successfully. On pipeline failure, it sends a command to a Raspberry Pi to send me a gentle electric shock to wake me up from sleep so that I can start working on the project. This is naturally set up to run on pre-merge as well as on a nightly schedule.

I always run my code on someone else's machine to check if it throws any errors. Most of the time, what happens is that we have all of the required tools installed and configured on our machine and when we give the same code to someone, it simply doesn't work due to some missing installations/configurations.

new series: Build review

being asked to make doodle jump as a code test wouldn't surprise me, about 4 years ago I was asked by one company to write my own animation system in unity and they didn't allow me to use any of the libraries in Unity to assist with it, and this was a fresh out of Uni job post and application.

This is so C++, spend the whole video trying to get the build system working 💀 Edit: but hey can you make another video where you look at the code? It would be interesting

I interview coders as part of my lead dev job, and I would say that my tolerance for the state of this submission would be entirely based on the level of the role. If I was hiring a junior, I would pass the code to one of my intermediates and have them debug and configure the code to something I can evaluate. Anything higher than junior, and I would reject the submission.

Don't put friction between you and the interviewer. Not an exact quote, but man, that nails it. You could have the most beautiful code on the planet, but if you make the interviewer jump through a bunch of hoops, you've already put yourself at the back of the line.